Use raw map key when it cannot be keywordized #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YAML allows the keys in a map to be arbitrary nodes: scalar, sequence
or mapping. [1] Prior to this commit, the *keywordize* option was
incorrectly setting map keys to `nil` for any keys that could not be
keywordized via `(keyword k)`. For example, a valid integer key
"123: 456" would be parsed as {nil 456}, because `(keyword 123)`
evals to nil.
This commit fixes the issue by keywordizing any map key that can be
keyworded, and otherwise using the raw key if `(keyword k)` is nil.
[1] http://www.yaml.org/spec/1.2/spec.html#id2764044
|
Hi, thanks for the fix! This repository appears unmaintained so I merged these into our fork, CircleCI-Archived/clj-yaml@cbaab59; I hope that's alright? Feel free to use our fork if you'd like. |
|
@startling Thanks for incorporating! Will switch over to using your fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YAML allows the keys in a map to be arbitrary nodes: scalar, sequence
or mapping. [1] Prior to this commit, the keywordize option was
incorrectly setting map keys to
nilfor any keys that could not bekeywordized via
(keyword k). For example, a valid integer key"123: 456" would be parsed as {nil 456}, because
(keyword 123)evals to nil.
This commit fixes the issue by keywordizing any map key that can be
keyworded, and otherwise using the raw key if
(keyword k)is nil.This fixes Github lancepantz/clj-yaml issue #15. [2]
[1] http://www.yaml.org/spec/1.2/spec.html#id2764044
[2] #15